ci: migrating to GitHub actions by JBAhire · Pull Request #57 · hypertrace/hypertrace-service

JBAhire · 2021-01-06T06:50:16Z

Description

Migrating to GitHub actions from CircleCI as per hypertrace/hypertrace#144

Testing

changes are updates as per discussions and workflow here: hypertrace/query-service#47

Checklist:

My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Any dependent changes have been merged and published in downstream modules

Documentation

https://docs.github.com/en/free-pro-team@latest/actions

github-actions · 2021-01-06T09:59:48Z

Unit Test Results

0 files 0 suites 0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 11e673c.

JBAhire · 2021-01-06T10:04:38Z

removed codecov, upload-artifact and publish action here as this repo doesn't generate any test reports: https://app.circleci.com/pipelines/github/hypertrace/hypertrace-service/257/workflows/f9676140-16d4-406b-8d14-afb568f57951/jobs/773/parallel-runs/0/steps/0-112

JBAhire · 2021-01-06T10:08:36Z

waiting for hypertrace/hypertrace-gradle-docker-plugins#22 to get merged as there's tag issue with e2e test here.

In case of PR, value of env variable GITHUB_REF is in the format of refs/pull/57/merge and docker image tag is returned as refspull57merge which results in e2e failure as we were using test tag.

I have made change in docker-compose file here so it will use GITHUB_HEAD_REF as tag for hypertrace service image.

kotharironak · 2021-01-06T12:44:27Z


  hypertrace:
-    image: hypertrace/hypertrace:test
+    image: hypertrace/hypertrace:${GITHUB_HEAD_REF}


Is this running as part of PR or after the merge to main?

it runs on both push and pull_request

But, github_head_ref will not be available on on push right? on push , we will get github.ref?

https://docs.github.com/en/free-pro-team@latest/actions/reference/context-and-expression-syntax-for-github-actions#github-context

yeah. I can see the issue now. As we have colon : here it will be syntax error rather than pulling latest image. One solution I can think of is running this in pull_request_target so even while building github_ref will be always main as we can see here: https://github.com/hypertrace/attribute-service/runs/1654802662?check_suite_focus=true#step:6:804 and build always happens before test so this image will be already there.

this will solve the issue.

making changes

What was wrong with test?

JBAhire · 2021-01-06T13:16:38Z

waiting for hypertrace/hypertrace-gradle-docker-plugins#22 to get merged as there's tag issue with e2e test here.

In case of PR, value of env variable GITHUB_REF is in the format of refs/pull/57/merge and docker image tag is returned as refspull57merge which results in e2e failure as we were using test tag.

I have made change in docker-compose file here so it will use GITHUB_HEAD_REF as tag for hypertrace service image.

This is no longer an dependency. We can move ahead without this change: #57 (comment)

kotharironak · 2021-01-06T13:59:04Z

      - '**/*.md'
-      - '**/*.txt'
-  pull_request:
+  pull_request_target:


If you go with this, we will need it during checkout

ref: ${{github.event.pull_request.head.ref}} repository: ${{github.event.pull_request.head.repo.full_name}}

See as followup PR if we can move to pull_request context.

* feat: add spaces support to gateway * chore: update query api * test: update gateway tests for spaces * refactor: moving protos around, code cleanup * fix: tricked by an out of order proto field

removes CCI and adds GHA

f7596f2

JBAhire requested review from buchi-busireddy, kotharironak, laxmanchekka and ravisingal as code owners January 6, 2021 06:50