ci: migrating to GitHub actions by JBAhire · Pull Request #98 · hypertrace/hypertrace-ingester

JBAhire · 2021-01-07T05:32:36Z

Description

Migrating to GitHub actions from CircleCI as per hypertrace/hypertrace#144

unlike other repositories, this one contains helm script because of macro repo approach. Using the same script instead of custom actions.

Testing

changes are updates as per discussions and workflow here: hypertrace/query-service#47

Checklist:

My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Any dependent changes have been merged and published in downstream modules

Documentation

https://docs.github.com/en/free-pro-team@latest/actions

kotharironak · 2021-01-08T06:00:29Z

    ;;
  package)
-    CHART_VERSION=$(git describe --abbrev=0)
+    CHART_VERSION=$(echo ${GITHUB_REF} | cut -d/ -f 3)


Here GITHUB_REF will be tag, right?

GITHUB_REF will be something like GITHUB_REF=refs/tags/0.5.0 so we are extracting tag from that.

kotharironak · 2021-01-08T06:10:06Z

+          HELM_GCS_CREDENTIALS: ${{ secrets.HELM_GCS_CREDENTIALS }}
+          HELM_GCS_REPOSITORY: ${{ secrets.HELM_GCS_REPOSITORY }}
+        run: |
+           ./.github/workflows/helm.sh package


We can explore using our github-action for replacing this. But, we can do a follow-up after migration.

github-actions · 2021-01-08T06:59:44Z

Unit Test Results

  47 files   47 suites 45s ⏱️
236 tests 236 ✔️ 0 💤 0 ❌

Results for commit c16397b.

JBAhire added 3 commits January 7, 2021 10:45

adds gha

4de0a55

uses helm script

43d5ae8

removes cci

18049cd

JBAhire requested a review from a team January 7, 2021 05:32