refactor: use http framework - #152
Merged
Merged
Conversation
aaron-steinfeld
commented
Jul 27, 2022
aaron-steinfeld
left a comment
aaron-steinfeld
left a comment
Contributor
Author
There was a problem hiding this comment.
Depends on hypertrace/hypertrace-core-graphql#105
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
=========================================
Coverage 22.77% 22.77%
Complexity 75 75
=========================================
Files 65 65
Lines 1739 1739
Branches 53 53
=========================================
Hits 396 396
Misses 1334 1334
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
marked this pull request as ready for review
July 27, 2022 23:09
tim-mwangi
reviewed
Jul 27, 2022
| private static final String SERVICE_NAME = "hypertrace-graphql"; | ||
|
|
||
| @Override | ||
| public List<HttpHandlerDefinition> buildHandlers(HttpContainerEnvironment environment) { |
Contributor
There was a problem hiding this comment.
isn't this in the hypertrace-core-graphql or is it needed
Contributor
Author
There was a problem hiding this comment.
it's in both - each defines its own service (and docker image) as legacy of when hypertrace and hypertrace-core had independent platforms.
tim-mwangi
approved these changes
Jul 27, 2022
skjindal93
pushed a commit
that referenced
this pull request
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use composable http service framework