Skip to content

Fix ENV variable issue for snyk on forked branch PR by non-member #132

Description

@JBAhire

Use Case

When PR is raised from forked branch by non-member circleci couldn't find ENV variables and throws error like below.
Screenshot 2020-11-30 at 8 53 43 PM

According to Aaron,
The repo has to be set up to pass secrets to forked PRs, but there are security implications to that so we deferred it.

Proposal

This a big think when it comes to contribution from non-members and we should address it asap. I found a FAQ around this in circleci support which are as below:

And this note here explains things better but this is not expected behavior from CI ideally (thoughts @jcchavezs ?):
https://circleci.com/docs/2.0/oss/#build-pull-requests-from-forked-repositories

we will need to investigate more and explore options if circleci is not able to this.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions