adds gradle action and modifies update-charts action - #9
Conversation
aaron-steinfeld
left a comment
aaron-steinfeld
left a comment
There was a problem hiding this comment.
please remove the .DS_Store file from the commit too (may want to add a .gitignore to the repo)
| WORKDIR /usr/local/bin | ||
|
|
||
| # Install Helm, helm-gcs plugin, git and openssh-client | ||
| RUN apk --update --no-cache add curl git openssh-client && \ |
There was a problem hiding this comment.
Given that this is no longer the main build image, it shouldn't need git or openssh.
Also nit: There's also no reason to clean up the image with the del/rm steps unless we're publishing it. Currently, it's just counterproductive since it's more work to do in each run (but maybe worth leaving since it's probably a very small amount of time and would be good if we ever decide to publish?).
There was a problem hiding this comment.
I would rather keep this in case we ever decide to publish. I have seen time it takes on test PR and it's in few seconds for complete execution so it's fine.
There was a problem hiding this comment.
That's fine - but just to clarify they were two separate comments - git + openssh are never needed any more (they were needed by circleci, since the image was also responsible for doing the checkout), so those should be removed. The second comment was about the cleanup which is what can stay in case we ever publish.
There was a problem hiding this comment.
Agree here that we should removegit + openssh.
There was a problem hiding this comment.
removing git is giving me error that git is required.
There was a problem hiding this comment.
ah - didn't notice that helm is using git for the plugin install. It probably doesn't need openssh if you're back in there since there's no auth happening, but who knows 🤷
| @@ -0,0 +1,23 @@ | |||
| FROM ghcr.io/openzipkin/alpine:3.12.1 | |||
|
|
|||
| # Use latest recommended version here | |||
There was a problem hiding this comment.
Since this repo houses all custom actions and this is only used by two of them, can we either move this into a directory like helm-docker or name it something to indicate what it's function is (e.g. helm.dockerfile).? In other words, when the next Dockerfile comes along for another action, how do we disambiguate?
3 participants
Description
adds custom actions for
helm-gcs-packagerimage as well as we are utilizing docker file here only but if we want to publish at any point we can push with this dockerfile.tested here: testing gradle action attribute-service#65