Repository navigation
Optimized the type of Content-Type to string from int for Hyperf\Tracer\Adapter\Reporter\HttpClientFactory. - #7791
Merged
Merged
Conversation
Cast Content-Length to string for Guzzle 7.11+ compatibility.
Verify the Zipkin reporter sends Content-Length as a string.
Content-Type to string from int for Hyperf\Tracer\Adapter\Reporter\HttpClientFactory.
limingxinleo
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Guzzle 7.11 deprecates non-string request header values, and Guzzle 8 requires header values to be strings or non-empty arrays. The Zipkin HTTP reporter currently assigns the integer returned by
strlen($payload)toContent-Length.In coroutine workloads, this deprecation may be captured by another active error handler and surface as an unrelated stream read failure.
What is changed and how does it work?
Cast the payload length to a string before passing the headers to Guzzle:
Tests
Added
HttpClientFactoryTest::testContentLengthHeaderIsStringto verify the reporter sendsContent-Lengthas a string.Failed asserting that 7 is identical to '7'.