Repository navigation
Optimized the parameters of method __call() to make them more standardized. - #7637
Merged
Merged
Conversation
Member
|
单测没过 |
Contributor
Author
|
Sorry I'm not too familiar with the github checks process.. I don't have the codebase set up on my computer.. Any chance someone can do this code fixing step please 🙏 |
Contributor
Author
|
OK I think I found what PHP CS issues needs to be fixed...I hope |
huangdijia
approved these changes
Nov 25, 2025
Member
|
容我再检查检查，明天合并，明天可以回复下，提醒下我，如果我忘了的话 |
kingIZZZY
commented
Nov 25, 2025
| * @return mixed | ||
| */ | ||
| public function __call($method, $parameters) | ||
| public function __call(string $name, array $arguments): mixed |
Contributor
Author
There was a problem hiding this comment.
I was trying to only fix code that uses Macroable::__call
Is this code also somehow affected by Macroable?
Contributor
Author
|
Good morning 🌞 |
limingxinleo
approved these changes
Nov 26, 2025
limingxinleo
changed the title
__call() to make them more standardized.
Contributor
Author
|
Thank you very very much! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would it be OK to make
Hyperf\Macroable\Macroable::__callto have explicit type hintsThis will help fix compatibility with downstream framework Hypervel: hypervel/components#277