Repository navigation
refactor(database): improve limit method validation in Query Builder - #7208
Merged
Merged
Conversation
huangdijia
commented
Dec 14, 2024
huangdijia
commented
Member
- Add type casting of limit value to integer
- Add explicit validation for negative limit values
- Throw InvalidArgumentException for negative limits
- Simplify control flow logic
- Add type casting of limit value to integer - Add explicit validation for negative limit values - Throw InvalidArgumentException for negative limits - Simplify control flow logic
huangdijia
marked this pull request as ready for review
February 5, 2025 12:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.