Skip to content

[LoRA, Xformers] Fix xformers lora#5201

Merged
sayakpaul merged 5 commits into
mainfrom
fix_xformers_lora
Sep 27, 2023
Merged

[LoRA, Xformers] Fix xformers lora#5201
sayakpaul merged 5 commits into
mainfrom
fix_xformers_lora

Conversation

@patrickvonplaten
Copy link
Copy Markdown
Contributor

@patrickvonplaten patrickvonplaten commented Sep 27, 2023

What does this PR do?

Fixes #5135

@patrickvonplaten patrickvonplaten changed the title [Xformers] Fix xformers lora [LoRA, Xformers] Fix xformers lora Sep 27, 2023
Comment thread src/diffusers/models/attention_processor.py
Copy link
Copy Markdown
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question and I am good to go.

Maybe a test? But definitely not a blocker.

@sayakpaul
Copy link
Copy Markdown
Member

UNet3D one seems to be flaky because I remember it from earlier PRs.

@patrickvonplaten
Copy link
Copy Markdown
Contributor Author

UNet3D one seems to be flaky because I remember it from earlier PRs.

Actually this looks more like the test was broken here, looking into it

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Sep 27, 2023

The documentation is not available anymore as the PR was closed or merged.

@sayakpaul
Copy link
Copy Markdown
Member

Checks passing. Merging.

@sayakpaul sayakpaul merged commit a584d42 into main Sep 27, 2023
@sayakpaul sayakpaul deleted the fix_xformers_lora branch September 27, 2023 16:16
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* fix xformers lora

* improve

* fix
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* fix xformers lora

* improve

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LoRA quality degradation -> xformers?

3 participants