Skip to content

Fix to fp16 unscaling bug#10783

Closed
iszihan wants to merge 1 commit into
huggingface:mainfrom
iszihan:fp16-bug
Closed

Fix to fp16 unscaling bug#10783
iszihan wants to merge 1 commit into
huggingface:mainfrom
iszihan:fp16-bug

Conversation

@iszihan
Copy link
Copy Markdown

@iszihan iszihan commented Feb 13, 2025

What does this PR do?

Fixes #10752 based on #9628.

Who can review?

@sayakpaul

Copy link
Copy Markdown
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch!

@sayakpaul
Copy link
Copy Markdown
Member

Can you run make style && make quality?

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@iszihan
Copy link
Copy Markdown
Author

iszihan commented Feb 13, 2025

Hmm is it supposed to just run under the repo? I get this


make style && make quality
ruff check examples scripts src tests utils benchmarks setup.py --fix
make: ruff: No such file or directory
make: *** [Makefile:57: style] Error 127

@sayakpaul
Copy link
Copy Markdown
Member

sayakpaul commented Feb 13, 2025

It's supposed to run from the root of the repository. And make sure you have the quality related deps installed: pip install -e .[quality].

@yiyixuxu
Copy link
Copy Markdown
Collaborator

yiyixuxu commented Mar 4, 2025

@bot /style

@ishan-modi
Copy link
Copy Markdown
Contributor

@yiyixuxu, this might be a stale PR, since changes are already there on main branch

@yiyixuxu
Copy link
Copy Markdown
Collaborator

yiyixuxu commented Mar 6, 2025

@ishan-modi

oh thanks for pointing it out, indeed!

@yiyixuxu
Copy link
Copy Markdown
Collaborator

yiyixuxu commented Mar 6, 2025

@iszihan
I'm closing this PR now since change it's already there. Sorry if we wasted your time. We have a style bot now so in the future we will be more efficient in merging PRs like this just needs the last step to fix code styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attempting to Unscale FP16 Gradients Bug

6 participants