Implemented New Method to Retrieve all Collaborators from a Repository#98
Implemented New Method to Retrieve all Collaborators from a Repository#98luciano-sabenca-movile wants to merge 2 commits into
Conversation
|
Kohsuke Kawaguchi » github-api #195 SUCCESS |
|
Just curious. Why not use |
|
Yes, I think that this is a solution to my use-case too. There isn't any particular reason to justify why I didn't use this solution, probably it will work fine too. I just thought the other solution as "more natural" or something like that :) . Anyway, I think that this pull-request is still valid, at least to fix this "bug"(I don't know if this is really a bug or just a design decision, in my opinion, it is more likely to be a bug, or, at least, a non-documented behavior). |
|
@luciano-sabenca-movile sorry for the late response. I will review this over the weekend. Thank you. |
The original commit has too many whitespace noise changes. Reference: #98
|
Unforunately your change has too many whitespace changes, presumably caused by your IDE. I recommend you disable auto-reformatting in IDE when you work on patches. I've extracted the code change in ba519f9, so this PR is effectively merged. |
|
Ok! In fact, it was caused by the IDE. |
4 participants
Hi.
I have a very ordinary use-case: I need to check if a Github user has access to a repository. Unfortunately, the Github's API doesn't provide a way to do it directly. To do it, I need to get all repos and check in which repositories the user is in repository's collaborators list. I tried to implement it, but a found a little problem: the method getCollaborators just return the first 30th collaborators. So, I've implemented a new method to retrieve all collaborators from a repository doing pagination just like several other methods from this library.
There is also, in this pull-request, fixes to some formatting issues and a unitary test-case to the new method.
Any question/suggestion, please, feel free to contact me.
Thanks in advance