Support the check-user-team-membership API call#75
Merged
kohsuke merged 1 commit intohub4j:masterfrom Mar 28, 2014
Merged
Conversation
|
Kohsuke Kawaguchi » github-api #136 SUCCESS |
rtyley
added a commit
to guardian/gu-who
that referenced
this pull request
Mar 12, 2014
This rewrite does better at avoiding the awful race-condition where we might add someone to the 'all' team immediately after they've been removed from the Org. We check org-membership /after/ we've established they're not in the 'all' team, and then add the user immediately, only if they /are/ a member of the Org. Note that membership of the 'all' team implies membership of the Org, so no need to do the `user.isMemberOf(org)` call if the user is already a member of the team. hub4j/github-api#75
kohsuke
added a commit
that referenced
this pull request
Mar 28, 2014
Support the check-user-team-membership API call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://developer.github.com/v3/orgs/teams/#get-team-member