Hey @bitwiseman - any chance of getting some PR review here? :)

@farmdawgnation
I know it's a bit to ask but I've just added a mocking framework that will let us run tests in offline mode in CI.

I've resolve the merge conflict, but haven't done a build or further test.

Could you try the instructions in CONTRIBUTING.md for creating new tests and snapshots of github response data? It is still a little rough around the edges, but I think it will be a big step forward for testing and stability. I've invited you to be a collaborator in the test repo that we're using. I think that's all you'll need from me. Thanks in advance.

If you don't have time, I'll get back to it later this week.

Could you try the instructions in CONTRIBUTING.md for creating new tests and snapshots of github response data? It is still a little rough around the edges, but I think it will be a big step forward for testing and stability. I've invited you to be a collaborator in the test repo that we're using. I think that's all you'll need from me. Thanks in advance.

I can give it a shot, but I may first attempt to write a test using the existing format for time's sake.

@bitwiseman I've gotten the wiremock data in place for the existing test I wrote and tests now pass locally for me. However, because I was added as an outside collaborator on a single repository it seems I don't have the ability to see what teams exist in github-api-test-org or tag them in reviews so I still can't write my test for the team pr reviews feature.

Could you please add a team that has the kohsuke2 user in it and make it so that I can see it?

Hm my tests are failing in CI, but they work locally. Seeing this in the CI log:

org.kohsuke.github.HttpException: Server returned HTTP response code: -1, message: 'null' for URL: http://localhost:63049/repos/github-api-test-org/github-api/pulls/298
	at org.kohsuke.github.PullRequestTest.testPullRequestReviewRequests(PullRequestTest.java:118)
Caused by: java.net.ConnectException: Connection refused (Connection refused)
	at org.kohsuke.github.PullRequestTest.testPullRequestReviewRequests(PullRequestTest.java:118)

What did I do wrong here?

@farmdawgnation
Sorry for slow response.
I've invited you to be an owner on github-api-test-org. That will give you rights to do whatever you need to.

Try deleting your wiremock data, rebasing/merging from master, and running again. I've made a bunch of fixes and improvements to the framework.

@farmdawgnation
FYI, I intend to get a new version published in the next week or two. I look forward to including this change.

Word, I'll try to get it in :)

Yay! tests pass!