Skip to content

Add GitHub API requests logging#530

Merged
bitwiseman merged 4 commits into
hub4j:masterfrom
bozaro:request-log
Oct 4, 2019
Merged

Add GitHub API requests logging#530
bitwiseman merged 4 commits into
hub4j:masterfrom
bozaro:request-log

Conversation

@bozaro
Copy link
Copy Markdown
Contributor

@bozaro bozaro commented Jul 19, 2019

This information is very useful on GitHub API rate limit exhaustion investigation.

@bitwiseman bitwiseman closed this Aug 24, 2019
@bitwiseman bitwiseman reopened this Aug 24, 2019
@bitwiseman
Copy link
Copy Markdown
Member

@bozaro
This is looks reasonable. Need some tests for it. Maybe you can try out the mocking framework, I've added and create some tests the verify the logging output?

@bitwiseman bitwiseman merged commit 78abb2e into hub4j:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants