Added method to list authorizations#481
Conversation
Fixes issue hub4j#459
bitwiseman
left a comment
There was a problem hiding this comment.
Excellent! How about some tests as well?
- Added missing brace at end of listMyAuthorizations(). - Added unit test for listMyAuthorizations().
|
@bitwiseman I added a basic unit test. Can you please check? I'm not sure how to check that the authorizations themselves are correct, since they depend on the user running the test. Can I change to a "known user" in the test itself? |
|
@martinvanzijl Kohsuke had a separate dummy login that he used for this, but that doesn't scale to more people. Where possible I'd like tests to use the You can then add checks against that stable data and anyone running the test should get the same result. Maybe mark the test using the FYI: I'd like to have robust tests that can be re-snapshotted freely, but if that can't be accomplished without a lot of extra work, I'm okay with tests that verify the functionality in CI using canned data that may require work to update if the tests change. |
Fixes issue #459.
Added method
GitHub.listMyAuthorizations().