Add issue events API#479
Merged
Merged
Conversation
bitwiseman
requested changes
May 17, 2019
Member
bitwiseman
left a comment
bitwiseman
left a comment
There was a problem hiding this comment.
Cool, thanks! This looks reasonable to me. Can you add some tests?
bitwiseman
reviewed
Oct 4, 2019
…zijl/github-api into issue_376_issue_events
…zijl/github-api into issue_376_issue_events
- Created separate class for GHIssueEvent instead of nested classes. - Renamed test class accordingly. Other fixes: - Changed id type to long. - Updated test cases. - Added toString() method.
Contributor
Author
|
I've uploaded my latest progress. I want to make the unit tests more robust by creating an issue within the test itself, editing it and making sure the appropriate events are created. I also want to test the fields of the |
Member
|
Cool just tell me when you're ready for review. |
Contributor
Author
|
@bitwiseman |
bitwiseman
approved these changes
Oct 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #376 (add issue events API).
Added the following methods: