-
Notifications
You must be signed in to change notification settings - Fork 775
Allows to define page size for repository lists and other API enhancements #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f52b4a2
Allows to define page size for repository lists.
lucamilanesio 2fb3f31
GHRepository owner is NOT a GHUser but more generically a GHPerson.
lucamilanesio 096c965
Allows fetching pull requests by knowing repo-name and owner.
lucamilanesio 19ec332
Gets commit details of a pull request.
lucamilanesio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
139 changes: 139 additions & 0 deletions
139
src/main/java/org/kohsuke/github/GHPullRequestCommitDetail.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| /* | ||
| * The MIT License | ||
| * | ||
| * Copyright (c) 2013, Luca Milanesio | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in | ||
| * all copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| */ | ||
| package org.kohsuke.github; | ||
|
|
||
| import java.net.URL; | ||
| import java.util.Date; | ||
|
|
||
| /** | ||
| * Commit detail inside a {@link GHPullRequest}. | ||
| * | ||
| * @author Luca Milanesio | ||
| */ | ||
| public class GHPullRequestCommitDetail { | ||
|
|
||
| public static class Authorship { | ||
| String name; | ||
| String email; | ||
| String date; | ||
|
|
||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| public String getEmail() { | ||
| return email; | ||
| } | ||
|
|
||
| public Date getDate() { | ||
| return GitHub.parseDate(date); | ||
| } | ||
| } | ||
|
|
||
| public static class Tree { | ||
| String sha; | ||
| String url; | ||
|
|
||
| public String getSha() { | ||
| return sha; | ||
| } | ||
|
|
||
| public URL getUrl() { | ||
| return GitHub.parseURL(url); | ||
| } | ||
| } | ||
|
|
||
| public static class Commit { | ||
| Authorship author; | ||
| Authorship committer; | ||
| String message; | ||
| Tree tree; | ||
| String url; | ||
| int comment_count; | ||
|
|
||
| public Authorship getAuthor() { | ||
| return author; | ||
| } | ||
|
|
||
| public Authorship getCommitter() { | ||
| return committer; | ||
| } | ||
|
|
||
| public String getMessage() { | ||
| return message; | ||
| } | ||
|
|
||
| public URL getUrl() { | ||
| return GitHub.parseURL(url); | ||
| } | ||
|
|
||
| public int getComment_count() { | ||
| return comment_count; | ||
| } | ||
| } | ||
|
|
||
| public static class CommitPointer { | ||
| String sha; | ||
| String url; | ||
| String html_url; | ||
|
|
||
| public URL getUrl() { | ||
| return GitHub.parseURL(url); | ||
| } | ||
|
|
||
| public URL getHtml_url() { | ||
| return GitHub.parseURL(html_url); | ||
| } | ||
|
|
||
| public String getSha() { | ||
| return sha; | ||
| } | ||
| } | ||
|
|
||
| String sha; | ||
| Commit commit; | ||
| String url; | ||
| String html_url; | ||
| String comments_url; | ||
| CommitPointer[] parents; | ||
|
|
||
| public String getSha() { | ||
| return sha; | ||
| } | ||
| public Commit getCommit() { | ||
| return commit; | ||
| } | ||
| public URL getApiUrl() { | ||
| return GitHub.parseURL(url); | ||
| } | ||
| public URL getUrl() { | ||
| return GitHub.parseURL(html_url); | ||
| } | ||
| public URL getCommentsUrl() { | ||
| return GitHub.parseURL(comments_url); | ||
| } | ||
| public CommitPointer[] getParents() { | ||
| return parents; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I know why you wanted methods like this (to avoid unnecessary REST API calls to
getRepository()), but I don't want the library to become full of these short-cuts.To address this without cluttering the API, I think we need to defer the REST call to retrieve the state of the repository. So I tweaked your commits and removed this method. I hope you are OK with this for the time being.