Added a new method to validate the GitHub API URL#232
Conversation
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
Hm... PR builder is dead |
|
@oleg-nenashev AFAIK, the test suite require local configuration. Was there a PR Builder configured in this repo? |
|
Yep. It has been configured on Kohsuke's beescloud account. I'm looking for it |
There was a problem hiding this comment.
Unrelated to commit feature change.
There was a problem hiding this comment.
Indeed, I'll wait to know the maintainer's opinion.
There was a problem hiding this comment.
Never mix 2 unrelated changes in one when it possible. FB absolutely not related to Added a new method to validate the GitHub API URL
There was a problem hiding this comment.
@oleg-nenashev @KostyaSha I agree. I'll change it.
|
I have a mixed feeling about adding more I've massaged this PR somewhat by the following commit. |
|
@kohsuke Thanks for your time. I left |
@reviewbybees specially, @oleg-nenashev