tweaks to enable access to github enterprise instances#21
Closed
toddtomkinson wants to merge 1 commit into
Closed
Conversation
… else (assuming anything else is an enterprise instance)
|
Kohsuke Kawaguchi » github-api #36 SUCCESS |
|
@kohsuke: it would be very nice if we could get this patch in. Is there anything I can do to speed up the merge? Thanks! |
|
@kohsuke @toddtomkinson @edrevo Seems like a few weeks have passed without any activity on this. Is there anything I can do to help get this in faster? |
Collaborator
|
My apologies. I believe my integrating the pull request #24 fixed this. |
Author
|
Sorry, I haven't been getting these updates... I'm happy that everything is fixed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The api on github enterprise instances is available at /api/v3. This change looks at the githubServer parameter and sets the 'ApiURL' accordingly.
Also added another constructor that takes the githubServer as a parameter along with login, password, and apiToken.