Allow query parameters for listInstallations query#1747
Closed
dunningdan wants to merge 0 commit into
Closed
Conversation
bitwiseman
requested changes
Nov 20, 2023
Member
bitwiseman
left a comment
There was a problem hiding this comment.
Other methods like this with query parameters in their endpoints, either use a query builder or take the specific parameter(s), in this case that would be Date since:
public PagedIterable<GHAppInstallation> listInstallations(final Date since) {
Contributor
Author
|
@bitwiseman sorry about the closed PR. I went to sync the PR fork and accidently removed my commits which cause this to close. I made the change you suggested but it's now at: #1748 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a change to allow the option to pass in the
sinceparameter per https://developer.github.com/v3/apps/#list-installations.Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: