Skip to content

Allow query parameters for listInstallations query#1747

Closed
dunningdan wants to merge 0 commit into
hub4j:mainfrom
dunningdan:main
Closed

Allow query parameters for listInstallations query#1747
dunningdan wants to merge 0 commit into
hub4j:mainfrom
dunningdan:main

Conversation

@dunningdan
Copy link
Copy Markdown
Contributor

@dunningdan dunningdan commented Nov 20, 2023

Description

Added a change to allow the option to pass in the since parameter per https://developer.github.com/v3/apps/#list-installations.

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Copy link
Copy Markdown
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other methods like this with query parameters in their endpoints, either use a query builder or take the specific parameter(s), in this case that would be Date since:

public PagedIterable<GHAppInstallation> listInstallations(final Date since) {

@bitwiseman bitwiseman changed the title Allow query parameters for listOrganization query Allow query parameters for listInstallations query Nov 20, 2023
@dunningdan dunningdan closed this Nov 21, 2023
@dunningdan
Copy link
Copy Markdown
Contributor Author

@bitwiseman sorry about the closed PR. I went to sync the PR fork and accidently removed my commits which cause this to close. I made the change you suggested but it's now at: #1748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants