CRUD repository variable#1668
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
============================================
+ Coverage 79.93% 79.98% +0.05%
- Complexity 2208 2221 +13
============================================
Files 212 213 +1
Lines 6687 6719 +32
Branches 364 365 +1
============================================
+ Hits 5345 5374 +29
- Misses 1128 1131 +3
Partials 214 214
☔ View full report in Codecov by Sentry. |
bitwiseman
left a comment
There was a problem hiding this comment.
I'm sorry about this review. You've done solid work here, including providing tests.
I didn't properly think through the PR the introduced GHRepositoryVariables. My bad. But now that I see there's more to them, I'd like to do this API better. Are you up for it?
If you're strongly opposed, I'm open to alternatives.
no worries @bitwiseman. I agree you !! |
|
@bitwiseman, I have applied the same pattern as GHLabel. |
47245f6 to
4cbae90
Compare
Description
Methods to create and update repository variables:
Before submitting a PR:
mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: