fix #145 GHTeam.getMembers() does not page properly#146
Merged
kohsuke merged 1 commit intohub4j:masterfrom Feb 14, 2015
if6was9:fix-get-members-paging
Merged
fix #145 GHTeam.getMembers() does not page properly#146kohsuke merged 1 commit intohub4j:masterfrom if6was9:fix-get-members-paging
kohsuke merged 1 commit intohub4j:masterfrom
if6was9:fix-get-members-paging
Conversation
|
Kohsuke Kawaguchi » github-api #257 SUCCESS |
|
Kohsuke Kawaguchi » github-api #258 SUCCESS |
Collaborator
|
Does I wish the method returned |
Author
|
The while loop iterates through all the pages and collects all the GHUser items. The immutable set isn't strictly necessary. It could be removed with no consequence. I agree about the return type. I didn't want to modify the API...just fix the implementation. |
kohsuke
added a commit
that referenced
this pull request
Feb 14, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHTeam.getMembers() would only return the first 30 members of an organization. This fixes that by reading each page of results.