Skip to content

Put mockito in the test scope.#139

Merged
suryagaddipati merged 1 commit intohub4j:masterfrom
farmdawgnation:mocking-scope
Dec 19, 2014
Merged

Put mockito in the test scope.#139
suryagaddipati merged 1 commit intohub4j:masterfrom
farmdawgnation:mocking-scope

Conversation

@farmdawgnation
Copy link
Copy Markdown
Contributor

I was having issues in a downstream project from github-api where mockito was appearing on the classpath where it shouldn't. I ran some dependency analysis and found that the inclusion was because of its mention in github-api without the test scope designation.

@buildhive
Copy link
Copy Markdown

Kohsuke Kawaguchi » github-api #249 SUCCESS
This pull request looks good
(what's this?)

@rtyley
Copy link
Copy Markdown
Contributor

rtyley commented Dec 2, 2014

Looks like this is a duplicate of #140 ? Entirely valid issue though!

suryagaddipati added a commit that referenced this pull request Dec 19, 2014
@suryagaddipati suryagaddipati merged commit e15f7a5 into hub4j:master Dec 19, 2014
@farmdawgnation farmdawgnation deleted the mocking-scope branch December 19, 2014 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants