Allow to use custom HttpConnector when only OAuth token is given#124
Merged
Conversation
|
Kohsuke Kawaguchi » github-api #225 SUCCESS |
ohtake
added a commit
to ohtake/ghprb-plugin
that referenced
this pull request
Sep 4, 2014
kohsuke
added a commit
that referenced
this pull request
Sep 4, 2014
Allow to use custom HttpConnector when only OAuth token is given
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old pull request is #120.
If you use
GitHub.connectUsingOAuth(String oauthAccessToken)orGitHub.connectUsingOAuth(String githubServer, String oauthAccessToken), the constructor ofGitHubcalls#getMyself.Because there is no way to call
#setConnectorbefore the construction,#getMyselfwill fail if the server is behind proxies.This pull request allows library users to use custom HttpConnector when only OAuth token is given.
Example usage is: