Use issues endpoints for pull requests#123
Merged
kohsuke merged 2 commits intoSep 4, 2014
Merged
Conversation
If the test assertion fails, we want the pull-request to be closed anyway. You can't have more than one pull-request merging a given branch into another, so leaving the PR hanging will cause subsequent test runs to fail in setup.
Setting labels and assignee on Pull requests failed silently, because the API endpoint being hit contained '/pulls/' rather than '/issues/'. "Every pull request is an issue, but not every issue is a pull request. For this reason, “shared” actions for both features, like manipulating assignees, labels and milestones, are provided within the Issues API." https://developer.github.com/v3/pulls/#labels-assignees-and-milestones
|
Kohsuke Kawaguchi » github-api #224 SUCCESS |
kohsuke
added a commit
that referenced
this pull request
Sep 4, 2014
…uests Use issues endpoints for pull requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting labels and assignee on Pull requests failed silently, because the API endpoint being hit contained '/pulls/' rather than '/issues/'.
https://developer.github.com/v3/pulls/#labels-assignees-and-milestones