Skip to content

Commit be70904

Browse files
committed
net/http/cgi: skip exec test on darwin/arm
Change-Id: I2fc3cf94b465bf9d7ff8d7bf935b45e334b401e3 Reviewed-on: https://go-review.googlesource.com/6180 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
1 parent 940f22e commit be70904

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

src/net/http/cgi/matryoshka_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ import (
2424
// This test is a CGI host (testing host.go) that runs its own binary
2525
// as a child process testing the other half of CGI (child.go).
2626
func TestHostingOurselves(t *testing.T) {
27-
if runtime.GOOS == "nacl" {
28-
t.Skip("skipping on nacl")
27+
if runtime.GOOS == "nacl" || (runtime.GOOS == "darwin" && runtime.GOARCH == "arm") {
28+
t.Skipf("skipping on %s/%s", runtime.GOOS, runtime.GOARCH)
2929
}
3030

3131
h := &Handler{
@@ -93,8 +93,8 @@ func (w *limitWriter) Write(p []byte) (n int, err error) {
9393
// If there's an error copying the child's output to the parent, test
9494
// that we kill the child.
9595
func TestKillChildAfterCopyError(t *testing.T) {
96-
if runtime.GOOS == "nacl" {
97-
t.Skip("skipping on nacl")
96+
if runtime.GOOS == "nacl" || (runtime.GOOS == "darwin" && runtime.GOARCH == "arm") {
97+
t.Skipf("skipping on %s/%s", runtime.GOOS, runtime.GOARCH)
9898
}
9999

100100
defer func() { testHookStartProcess = nil }()
@@ -140,8 +140,8 @@ func TestKillChildAfterCopyError(t *testing.T) {
140140
// Test that a child handler writing only headers works.
141141
// golang.org/issue/7196
142142
func TestChildOnlyHeaders(t *testing.T) {
143-
if runtime.GOOS == "nacl" {
144-
t.Skip("skipping on nacl")
143+
if runtime.GOOS == "nacl" || (runtime.GOOS == "darwin" && runtime.GOARCH == "arm") {
144+
t.Skipf("skipping on %s/%s", runtime.GOOS, runtime.GOARCH)
145145
}
146146

147147
h := &Handler{

0 commit comments

Comments
 (0)