Skip to content

Commit 4205400

Browse files
jshajsha
authored
Lower logDNSError to info level. (letsencrypt#5701)
These log lines are sometimes useful for debugging, but are a normal part of operation, not an error: Unbound will allow a response to timeout if the remote server is too slow.
1 parent 39c14f3 commit 4205400

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎bdns/dns.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ func logDNSError(
561561
}
562562
}
563563

564-
logger.Errf(
564+
logger.Infof(
565565
"logDNSError ID mismatch chosenServer=[%s] hostname=[%s] respHostname=[%s] queryType=[%s] err=[%s] msg=[%s] resp=[%s]",
566566
chosenServer,
567567
hostname,
@@ -572,7 +572,7 @@ func logDNSError(
572572
encodedResp)
573573
} else {
574574
// Otherwise log a general DNS error
575-
logger.Errf("logDNSError chosenServer=[%s] hostname=[%s] queryType=[%s] err=[%s]",
575+
logger.Infof("logDNSError chosenServer=[%s] hostname=[%s] queryType=[%s] err=[%s]",
576576
chosenServer,
577577
hostname,
578578
queryType,

‎va/http_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ func TestHTTPValidationDNSIdMismatchError(t *testing.T) {
343343
strings.Join(mockLog.GetAllMatching(`.*`), "\n"))
344344
}
345345
expectedRegex := regexp.MustCompile(
346-
`ERR: \[AUDIT\] logDNSError ID mismatch ` +
346+
`INFO: logDNSError ID mismatch ` +
347347
`chosenServer=\[mock.server\] ` +
348348
`hostname=\[id\.mismatch\] ` +
349349
`respHostname=\[id\.mismatch\.\] ` +

0 commit comments

Comments
 (0)