Skip to content

Commit 2262415

Browse files
committed
Merge pull request bitcoin#5214
eefb766 Rearrange initial config checks: AC, AM, compiler, libtool. Removed some repeated and unused prog checks. (kiwigb)
2 parents 2f76015 + eefb766 commit 2262415

1 file changed

Lines changed: 29 additions & 38 deletions

File tree

configure.ac

Lines changed: 29 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -14,42 +14,14 @@ AC_CONFIG_MACRO_DIR([build-aux/m4])
1414

1515
AC_CANONICAL_HOST
1616

17-
dnl By default, libtool for mingw refuses to link static libs into a dll for
18-
dnl fear of mixing pic/non-pic objects, and import/export complications. Since
19-
dnl we have those under control, re-enable that functionality.
20-
21-
case $host in
22-
*mingw*)
23-
lt_cv_deplibs_check_method="pass_all"
24-
;;
25-
esac
26-
27-
LT_INIT([disable-shared])
28-
2917
AH_TOP([#ifndef BITCOIN_CONFIG_H])
3018
AH_TOP([#define BITCOIN_CONFIG_H])
3119
AH_BOTTOM([#endif //BITCOIN_CONFIG_H])
3220

33-
# This m4 will only be used if a system copy cannot be found. This is helpful
34-
# on systems where autotools are installed but the pkg-config macros are not in
35-
# a default location. It is currently used for building on OSX where autotools
36-
# are preinstalled but pkg-config comes from macports or homebrew. It should
37-
# probably be removed when building on <= 10.6 is no longer supported.
38-
m4_include([pkg.m4])
39-
4021
dnl faketime breaks configure and is only needed for make. Disable it here.
4122
unset FAKETIME
4223

43-
if test "x${CXXFLAGS+set}" = "xset"; then
44-
CXXFLAGS_overridden=yes
45-
else
46-
CXXFLAGS_overridden=no
47-
fi
48-
49-
dnl ==============================================================
50-
dnl Setup for automake
51-
dnl ==============================================================
52-
24+
dnl Automake init set-up and checks
5325
AM_INIT_AUTOMAKE([no-define subdir-objects foreign])
5426

5527
dnl faketime messes with timestamps and causes configure to be re-run.
@@ -59,17 +31,27 @@ AM_MAINTAINER_MODE([enable])
5931
dnl make the compilation flags quiet unless V=1 is used
6032
m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
6133

62-
dnl Checks for programs.
34+
dnl Compiler checks (here before libtool).
35+
if test "x${CXXFLAGS+set}" = "xset"; then
36+
CXXFLAGS_overridden=yes
37+
else
38+
CXXFLAGS_overridden=no
39+
fi
6340
AC_PROG_CXX
64-
AC_PROG_CC
65-
AC_PROG_CPP
66-
AC_PROG_CXXCPP
67-
AC_PROG_INSTALL
68-
AC_PROG_OBJC
69-
AC_PROG_LN_S
7041
m4_ifdef([AC_PROG_OBJCXX],[AC_PROG_OBJCXX])
71-
AC_PROG_MKDIR_P
72-
AC_PROG_SED
42+
43+
dnl By default, libtool for mingw refuses to link static libs into a dll for
44+
dnl fear of mixing pic/non-pic objects, and import/export complications. Since
45+
dnl we have those under control, re-enable that functionality.
46+
case $host in
47+
*mingw*)
48+
lt_cv_deplibs_check_method="pass_all"
49+
;;
50+
esac
51+
dnl Libtool init checks.
52+
LT_INIT([disable-shared])
53+
54+
dnl Check/return PATH for base programs.
7355
AC_PATH_TOOL(AR, ar)
7456
AC_PATH_TOOL(RANLIB, ranlib)
7557
AC_PATH_TOOL(STRIP, strip)
@@ -81,6 +63,15 @@ AC_PATH_PROG([GIT], [git])
8163
AC_PATH_PROG(CCACHE,ccache)
8264
AC_PATH_PROG(XGETTEXT,xgettext)
8365
AC_PATH_PROG(HEXDUMP,hexdump)
66+
67+
# This m4 will only be used if a system copy cannot be found. This is helpful
68+
# on systems where autotools are installed but the pkg-config macros are not in
69+
# a default location. It is currently used for building on OSX where autotools
70+
# are preinstalled but pkg-config comes from macports or homebrew. It should
71+
# probably be removed when building on <= 10.6 is no longer supported.
72+
m4_include([pkg.m4])
73+
74+
dnl pkg-config check.
8475
PKG_PROG_PKG_CONFIG
8576

8677
# Enable wallet

0 commit comments

Comments
 (0)