feat: input-requires-label - All inputs require a label - #159
Merged
Merged
Conversation
Contributor
Author
|
I tried to fix the conflict, but because the version in the package.json is now I think package.json version needs to change, should I change it in this PR ? |
Member
|
Hi @olore, I'm actually working on that. I'll publish an update in the next hour. |
Contributor
Author
|
I just saw #259 and now I'm up to speed. Thanks for reviving this project! |
Member
|
You're welcome @olore, don't hesitate to join the discord channel to exchange about the project! |
thedaviddias
force-pushed
the
develop
branch
from
September 3, 2018 23:14
5cf8348 to
25843ac
Compare
thedaviddias
changed the title
Member
|
@olore do you want to solve the merge conflict or do you want me to fix this in a new PR? |
olore
force-pushed
the
input-requires-label
branch
from
May 16, 2020 23:04
da55c13 to
eb703c3
Compare
thedaviddias
approved these changes
May 16, 2020
thedaviddias
left a comment
thedaviddias
left a comment
Member
There was a problem hiding this comment.
Almost 4 years :D thanks for this new PR!
thedaviddias
added
accepted
and removed
triage
Contributor
|
@olore 💪❤ |
thedaviddias
pushed a commit
that referenced
this pull request
May 18, 2020
github-actions Bot
pushed a commit
that referenced
this pull request
May 18, 2020
# [0.13.0](v0.12.2...v0.13.0) (2020-05-18) ### Bug Fixes * add prettier and eslint ([#388](#388)) ([aba3249](aba3249)) * add semantic release test ([#399](#399)) ([616f9cd](616f9cd)) * ignore PULL_REQUEST_TEMPLATE.md ([30b0af2](30b0af2)) * use yml in semantic.yml ([86f6700](86f6700)) ### Features * Add tags checking rule - allows specify rules for any tag and validate that ([#384](#384)) ([475aaca](475aaca)) * added attr-no-unnecessary-whitespace rule ([#385](#385)) ([03bfd4f](03bfd4f)) * new rule: input-requires-label - All inputs require a label ([#159](#159)) ([5bd40fb](5bd40fb)) * new website for htmlhint.com ([#395](#395)) ([5d0d95f](5d0d95f))
Shinigami92
pushed a commit
that referenced
this pull request
May 19, 2020
thedaviddias
added a commit
that referenced
this pull request
Nov 11, 2020
Relates to #159 Signed-off-by: Antoine Leblanc <[email protected]> Co-authored-by: David Dias <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for accessibility.
Some references: