You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for writing this up with all the relevant links and information--that helps a ton! I'm game for dropping support for Python 3.3. I'll add it to the 1.0 milestone.
If someone has a compelling reason not to drop Python 3.3, please add a comment.
If someone has a compelling reason not to drop Python 3.3, please add a comment.
Historically the viewpoint I've taken is given we're vendored into pip we should support the same set of versions as pip does (to avoid any need for pip to fork html5lib).
Wow--I had no idea html5lib-python was vendored in pip. That's... interesting.
@gsnedders How do we figure out what versions of pip are supported? Are we just checking their current release to see what versions of Python it supports? For example, master tip still supports Python 3.3:
I think it makes sense for pip to vendor things, it needs to be able to install from a download with maybe no external net access except an internal PyPI server.
Here's the pip decision and PR to deprecate 3.3 in the next pip 10 and drop it in pip 11. pypa/pip#3796 pypa/pip#4355
Activity
willkg commentedon Nov 7, 2017
Thank you for writing this up with all the relevant links and information--that helps a ton! I'm game for dropping support for Python 3.3. I'll add it to the 1.0 milestone.
If someone has a compelling reason not to drop Python 3.3, please add a comment.
gsnedders commentedon Nov 7, 2017
Historically the viewpoint I've taken is given we're vendored into pip we should support the same set of versions as pip does (to avoid any need for pip to fork html5lib).
willkg commentedon Nov 7, 2017
Wow--I had no idea html5lib-python was vendored in pip. That's... interesting.
@gsnedders How do we figure out what versions of pip are supported? Are we just checking their current release to see what versions of Python it supports? For example, master tip still supports Python 3.3:
https://github.com/pypa/pip/blob/3998df351853c68274802502fead7607c8ab8eeb/setup.py#L54
hugovk commentedon Nov 7, 2017
I think it makes sense for pip to vendor things, it needs to be able to install from a download with maybe no external net access except an internal PyPI server.
Here's the pip decision and PR to deprecate 3.3 in the next pip 10 and drop it in pip 11.
pypa/pip#3796
pypa/pip#4355
Their latest stable docs say 2.6, 2.7, 3.3-3.5, pypy.
https://pip.pypa.io/en/stable/installing/#python-and-os-compatibility
Latest master says 2.7, 3.3-3.6, pypy.
https://github.com/pypa/pip/blob/master/docs/installing.rst#python-and-os-compatibility
gsnedders commentedon Nov 7, 2017
@willkg mostly @dstufft pinging me (or me him) when they drop stuff :)
willkg commentedon Nov 7, 2017
That makes sense!
Seems like we shouldn't drop support for 3.3 in html5lib-python 1.0. Beyond that, I'll leave this until you get pinged and we can drop it.