Migrate IexecERC20Delegate unit tests - #98
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #98 +/- ##
========================================
Coverage 83.00% 83.00%
========================================
Files 34 34
Lines 1077 1077
Branches 202 202
========================================
Hits 894 894
Misses 183 183 ☔ View full report in Codecov by Sentry. |
james-toussaint
marked this pull request as ready for review
July 30, 2024 15:35
zguesmi
reviewed
Jul 30, 2024
zguesmi
approved these changes
Jul 31, 2024
Comment on lines
+50
to
+52
| it('Should get total supply', async () => { | ||
| expect(await iexecPoco.totalSupply()).equal(totalSupplyBeforeFirstDeposit.add(value)); | ||
| }); |
Member
There was a problem hiding this comment.
This is also tested in IexecAccessors. Let's choose one of them.
Contributor
Author
There was a problem hiding this comment.
I would say both tests makes sense, here for instance testing https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/IERC20.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.