Some small tweaks, new tests and docs#1
Merged
ericduran merged 3 commits intoericduran:deploymentapifrom Feb 21, 2015
Merged
Conversation
0223d4a to
84ddd84
Compare
Owner
|
👍 💯 |
ericduran
added a commit
that referenced
this pull request
Feb 21, 2015
Some small tweaks, new tests and docs
Collaborator
Author
|
Thanks for fixing up those tests - totally slipped my mind that the short array syntax is only relatively recent. |
lol768
pushed a commit
that referenced
this pull request
Mar 4, 2015
Unit tests added for Github\Api\Search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a couple of quick changes:
Acceptheader to use it anymoreupdatemethod was a bit misleading/unclear. Per this page:As a result, I've renamed it to
updateStatusto try and prevent confusion.As for the tests:
In terms of documentation:
Thanks for your existing work on this, the existing code was nice to work with. Hopefully this can be pulled into knplabs/php-github-api soon.