Change 'staticfiles' to 'static' with new Django version - #95
Conversation
mdebono
left a comment
mdebono
left a comment
There was a problem hiding this comment.
Did the same change for myself and then found out there was this pull request. Thanks and would be nice for others to have this merged.
|
Hi, I ran into this problem (and fix) today. Will this be merged anytime soon? No pressure, I know people have stuff to do :) |
|
An easy bug to fix, but one everyone will encounter. Shouldn't take almost a year to merge this in, come on guys. |
|
This is in my backlog, but behind higher priority Python buildpack work. Also I first need to set up CI for this repo (likely Heroku CI which would have the added benefit of demonstrating that too). |
|
@edmorley this just needs to be merged, it's a relatively obscure django detail that has nothing to do with heroku itself, and is just a bump in an otherwise flawless tutorial. What's stopping you (or anyone in charge, really) from merging this no-brainer? |
797dbd1 to
0b0c0c7
Compare
|
Thank you for the PR! Sorry it's taken so long to review/merge -- I've now set up CI and Review Apps on this repo so it should be faster to validate from now on :-) |
8 participants
{% load staticfiles %} and {% load admin_static %} were deprecated in Django 2.1, and removed in Django 3.0. see last bullet here
Tried to follow the getting started guide and ran into this issue when going to the '/db' route. Would create a more consistent experience for all subsequent users for this guide in the future!