Fixes + Postgres#112
Closed
JbCourtois wants to merge 14 commits into
Closed
Conversation
Login/dev
Abadious
approved these changes
May 3, 2022
edmorley
requested changes
Jul 28, 2022
edmorley
left a comment
edmorley
left a comment
Member
There was a problem hiding this comment.
Thank you for the PR, and sorry for the extreme delay in replying.
There are now conflicts due to changes that have landed on main in the meantime. I also think some of these changes are best made in separate PRs, so they can be individually resolved/discussed.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a build compatible both locally (with
heroku local) and remotely (withheroku create)Django-heroku is not used because of the psycopg dependency that crashes on my OSX system, so we use dj-database-url with psycopg-binary instead.
We also fix pylints in the process.