Skip to content

Added class Car and Race with new methods and fields. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hashTagChill wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Added class Car and Race with new methods and fields. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 81 additions & 2 deletions src/main/java/Main.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,85 @@
import java.util.ArrayList;
import java.util.Scanner;

public class Main {
public static void main(String[] args) {
System.out.println("Hello world!");
Scanner scanner = new Scanner(System.in);
Race race = new Race();
ArrayList<Car> cars = new ArrayList<>();

System.out.println("Добро пожаловать в 24 часа Ле-Мана!!!");
for (int i = 1; i <= 3; i++) {
System.out.println("Введите название машины №" + i + ":");
String name = scanner.nextLine();

int speed = 0;
while (true) {
System.out.println("Введите скорость машины №" + i + ":");
try {
speed = Integer.parseInt(scanner.nextLine());
if (speed > 0 && speed <= 250) {

@ArturNurtdinov ArturNurtdinov Dec 22, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Минимальную и максимальную допустимые скорости лучше вынести в константы с говорящими названиями для повышения читабельности кода

break;
} else {
System.out.println("Введена неправильная скорость! Скорость должна быть от 1 до 250.");
}
} catch (NumberFormatException e) {
System.out.println("Введите корректное целое число от 1 до 250.");
}
}

Car car = new Car(name, speed);
cars.add(car);
}

for (Car car : cars) {
race.findLeader(car);

@ArturNurtdinov ArturNurtdinov Dec 22, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

От хранения массива машин можно избавиться, если прямо при чтении данных определять и запоминать только победителя. Таким образом, программа будет работать быстрее и требовать меньше памяти

}

System.out.println("Самая быстрая машина: " + race.getLeaderName());
}
}

class Car {
private String name;
private int speed;
Comment on lines +43 to +44

@ArturNurtdinov ArturNurtdinov Dec 22, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поля лучше пометить final, тем самым исключив возможность их модификации извне

Плюс можно убрать private и удалить геттеры, если ты сделаешь поля final - это будет так же безопасно и лаконично, как с геттерами


public Car(String name, int speed) {
this.name = name;
this.speed = speed;
}

public String getName() {
return name;
}
}

public int getSpeed() {
return speed;
}
}

class Race {
private String leaderName;
private int maxDistance;

public void findLeader(Car car) {
int distance = car.getSpeed() * 24;
if (distance > maxDistance) {
maxDistance = distance;
leaderName = car.getName();
}
}

public String getLeaderName() {
return leaderName;
}
}