Repository navigation
Added class Car and Race with new methods and fields. - #1
Open
hashTagChill wants to merge 1 commit into
Open
hashTagChill wants to merge 1 commit into
hashTagChill wants to merge 1 commit into
Conversation
In Main class added logic to work with class Race and Car, to find leader of the race from user input
| System.out.println("Введите скорость машины №" + i + ":"); | ||
| try { | ||
| speed = Integer.parseInt(scanner.nextLine()); | ||
| if (speed > 0 && speed <= 250) { |
There was a problem hiding this comment.
Минимальную и максимальную допустимые скорости лучше вынести в константы с говорящими названиями для повышения читабельности кода
Comment on lines
+43
to
+44
| private String name; | ||
| private int speed; |
There was a problem hiding this comment.
Поля лучше пометить final, тем самым исключив возможность их модификации извне
Плюс можно убрать private и удалить геттеры, если ты сделаешь поля final - это будет так же безопасно и лаконично, как с геттерами
| } | ||
|
|
||
| for (Car car : cars) { | ||
| race.findLeader(car); |
There was a problem hiding this comment.
От хранения массива машин можно избавиться, если прямо при чтении данных определять и запоминать только победителя. Таким образом, программа будет работать быстрее и требовать меньше памяти
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Main class added logic to work with class Race and Car, to find leader of the race from user input