Conversation
Elevate python installation on Travis CI to fix ARM setup Rewrite ARM Travis CI setup
Add bdist_wheel distribution to automated Travis CI deployment
Specific Exceptions: Adapting neousys (+ bugfixes & simplifications)
Specific Exceptions: Adapting kvaser
Specific Exceptions: Adapting virtual
…direction-of-can-fd Add msg direction for CAN-FD in BlfReader
Improve according to pylint
Co-authored-by: zariiii9003 <[email protected]>
1210 Add compressed file methods
Enable mypy for vector interface
…n-removed Remove unnssesary conversion to list
Improve IO typing
* Adress pylint issues * Format code with black * Fix line-too-long * Fix abstract-method * Fix line-too-long Co-authored-by: felixdivo <[email protected]>
* Fix deprecation in test case * Modernize example * Better test_asyncio_notifier() * Format code with black * Attempt to fix typing; improve docs * try to fix mypy failure with type annotation * Better bus handling * Doc fix * Fix type errors in notifier.py * Format code with black * Fix example typing * Fix too long line in doc * Switch name from Listenable to MessageRecipient Co-authored-by: felixdivo <[email protected]>
* Fix entry_points deprectaion * Format code with black * Undo change that shall be in a separate PR Co-authored-by: felixdivo <[email protected]>
* Adds a CONTRIBUTING.md file which links to our docs * Remove email addresses from contributors.txt * Add github handles for new contributors * Update history.rst
* If parsed data has shortened, overwrite end of line with spaces This bug could easily be replicated by running: `python can_viewer.py -c vcan0 -i socketcan -d "123:>BB"` In another terminal send: `cansend vcan0 123#FFFF` Followed by: `cansend vcan0 123#0001` * Fill until end of available line after parsed data as suggedted by @zariiii9003
* Pass flags instead of flags_t type for USB2CAN * Remove usb2can unused open arguments for super Co-authored-by: Jacob Erickson <[email protected]>
Co-authored-by: Nadhmi JAZI <[email protected]>
# Conflicts: # .travis.yml # CHANGELOG.txt # can/__init__.py # can/bus.py # can/interfaces/canalystii.py # can/interfaces/ics_neovi/neovi_bus.py # can/interfaces/ixxat/canlib.py # can/interfaces/socketcan/constants.py # can/interfaces/socketcan/socketcan.py # can/interfaces/vector/canlib.py # can/interfaces/vector/vxlapi.py # can/io/asc.py # can/io/blf.py # can/io/canutils.py # can/io/csv.py # can/message.py # can/player.py # doc/development.rst # setup.py # test/data/logfile.asc # test/logformats_test.py # test/test_cyclic_socketcan.py # test/test_message_class.py
Codecov Report
@@ Coverage Diff @@
## master #1260 +/- ##
==========================================
+ Coverage 65.96% 65.99% +0.03%
==========================================
Files 63 86 +23
Lines 5855 8905 +3050
==========================================
+ Hits 3862 5877 +2015
- Misses 1993 3028 +1035 |
Owner
Author
|
I don't think there is any point of requesting a review on a 30k diff! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges
masterintodevelop(accepting develop for all conflicts).Might take the opportunities to get with the times and rename
master->mainin github too.