Skip to content

Address pylint issues#1239

Merged
felixdivo merged 6 commits intodevelopfrom
felixdivo-cleanup-pylint-issues
Jan 27, 2022
Merged

Address pylint issues#1239
felixdivo merged 6 commits intodevelopfrom
felixdivo-cleanup-pylint-issues

Conversation

@felixdivo
Copy link
Copy Markdown
Collaborator

@felixdivo felixdivo commented Jan 27, 2022

Continues after #1238. Part of #1230.

@felixdivo felixdivo added the QA about improving and maintaining the quality of the library label Jan 27, 2022
@felixdivo felixdivo added this to the 4.0.0 Release milestone Jan 27, 2022
@felixdivo felixdivo requested a review from zariiii9003 January 27, 2022 14:16
@felixdivo felixdivo self-assigned this Jan 27, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 27, 2022

Codecov Report

Merging #1239 (f9cd227) into develop (28513eb) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

@@             Coverage Diff             @@
##           develop    #1239      +/-   ##
===========================================
- Coverage    65.88%   65.88%   -0.01%     
===========================================
  Files           86       86              
  Lines         8885     8884       -1     
===========================================
- Hits          5854     5853       -1     
  Misses        3031     3031              

@felixdivo felixdivo marked this pull request as ready for review January 27, 2022 14:24
Copy link
Copy Markdown
Collaborator

@zariiii9003 zariiii9003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@felixdivo felixdivo merged commit f1808ed into develop Jan 27, 2022
@felixdivo felixdivo deleted the felixdivo-cleanup-pylint-issues branch January 27, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA about improving and maintaining the quality of the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants