Improve IO typing#1238
Merged
zariiii9003 merged 1 commit intohardbyte:developfrom Jan 27, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1238 +/- ##
===========================================
+ Coverage 65.84% 65.88% +0.04%
===========================================
Files 86 86
Lines 8877 8885 +8
===========================================
+ Hits 5845 5854 +9
+ Misses 3032 3031 -1 |
felixdivo
approved these changes
Jan 27, 2022
Collaborator
felixdivo
left a comment
felixdivo
left a comment
There was a problem hiding this comment.
I think we can merge this as-is and fix the pylint issues in a subsequent PR to keep the diffs simple and clear.
Collaborator
|
Nice! We're getting there ... |
felixdivo
added
the
QA
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.