Skip to content

Enable mypy for vector interface#1229

Merged
zariiii9003 merged 3 commits intohardbyte:developfrom
zariiii9003:vector_mypy
Jan 27, 2022
Merged

Enable mypy for vector interface#1229
zariiii9003 merged 3 commits intohardbyte:developfrom
zariiii9003:vector_mypy

Conversation

@zariiii9003
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 25, 2022

Codecov Report

Merging #1229 (50071cc) into develop (2807da1) will increase coverage by 0.04%.
The diff coverage is 84.90%.

@@             Coverage Diff             @@
##           develop    #1229      +/-   ##
===========================================
+ Coverage    65.86%   65.90%   +0.04%     
===========================================
  Files           86       86              
  Lines         8873     8882       +9     
===========================================
+ Hits          5844     5854      +10     
+ Misses        3029     3028       -1     

Copy link
Copy Markdown
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 😄

Comment thread can/interfaces/vector/canlib.py
Comment thread can/interfaces/vector/canlib.py Outdated
Comment thread can/interfaces/vector/canlib.py Outdated
Comment thread can/interfaces/vector/canlib.py
@felixdivo felixdivo added this to the 4.0.0 Release milestone Jan 26, 2022
@felixdivo felixdivo added the QA about improving and maintaining the quality of the library label Jan 26, 2022
@felixdivo
Copy link
Copy Markdown
Collaborator

Two mypy errors have popped up:

can/interfaces/vector/canlib.py:22: error: Incompatible types in assignment (expression has type "None", variable has type "Callable[[int, int], int]")
can/interfaces/vector/canlib.py:22: error: Incompatible types in assignment (expression has type "None", variable has type "int")

@zariiii9003 zariiii9003 merged commit 00e2302 into hardbyte:develop Jan 27, 2022
@zariiii9003 zariiii9003 deleted the vector_mypy branch January 27, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA about improving and maintaining the quality of the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants