Skip to content

Television support - #157

Merged
yfre merged 12 commits into
hap-java:masterfrom
yfre:television_support
Feb 7, 2022
Merged

yfre merged 12 commits into
hap-java:masterfrom
yfre:television_support

Conversation

@yfre

@yfre yfre commented Feb 3, 2022 •

Copy link
Copy Markdown
Contributor

adding television service with television speaker and input source services and a number of characteristics

inspired by @dfrommi work #81 (comment)
and HAP-NodeJS implementation.

this PR also fixed UUID of HAP Version.

once it is merged, i will submit updated sample test client with television accessory mocked

Signed-off-by: Eugen Freiter [email protected]

Eugen Freiter added 2 commits February 3, 2022 22:42
Signed-off-by: Eugen Freiter <[email protected]>
@yfre yfre linked an issue Feb 3, 2022 that may be closed by this pull request
@ccutrer

ccutrer commented Feb 3, 2022

Copy link
Copy Markdown
Member

I'll try to at least skim this code in the next couple days. I'd be really excited to have television in OpenHAB!

@yfre

yfre commented Feb 3, 2022

Copy link
Copy Markdown
Contributor Author

I'll try to at least skim this code in the next couple days. I'd be really excited to have television in OpenHAB!

thank you. just to put expectation rights - with this we cannot control Apple TV. but we can pretend to be apple tv :) and can receive commands from virtual remote on iOS

the code itself is lot of copy&paste and typing. it is following the same approach as other accessories. the additional logic or so.

@ccutrer

ccutrer commented Feb 4, 2022 •

Copy link
Copy Markdown
Member

thank you. just to put expectation rights - with this we cannot control Apple TV. but we can pretend to be apple tv :) and can receive commands from virtual remote on iOS

Yup. No AirPlay either. It's just on/off and switching inputs. I have an LG TV that has HomeKit built in, so I know what to expect. Except my TV uses Bluetooth as its transport, and it's incredibly unreliable. I can't wait to publish it from OpenHAB instead, using its IP API which is far more reliable.

Eugen Freiter and others added 10 commits February 4, 2022 14:02
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
@yfre
yfre merged commit 54908ff into hap-java:master Feb 7, 2022
@iRayanKhan

Copy link
Copy Markdown

thank you. just to put expectation rights - with this we cannot control Apple TV. but we can pretend to be apple tv :) and can receive commands from virtual remote on iOS

Yup. No AirPlay either. It's just on/off and switching inputs. I have an LG TV that has HomeKit built in, so I know what to expect. Except my TV uses Bluetooth as its transport, and it's incredibly unreliable. I can't wait to publish it from OpenHAB instead, using its IP API which is far more reliable.

AirPlay 1 has been available, with AirPlay 2 (audio) being in beta for a bit now using shairport-sync.

In regards to video support, this project can do it in Java.

@ccutrer

ccutrer commented Feb 8, 2022

Copy link
Copy Markdown
Member

AirPlay 1 has been available, with AirPlay 2 (audio) being in beta for a bit now using shairport-sync.

Indeed. I've contributed to that project a bit as well. The point still stands - an AppleTV speaks both HomeKit and AirPlay 2. HAP-Java is just HomeKit. shairport-sync is just AirPlay 2. HomeKit is the control aspect, AirPlay is the actual streaming media aspect.

@yfre
yfre deleted the television_support branch February 12, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TV accessory

3 participants