[v22.x] Backport: "module: add --experimental-transform-types flag"#54373
Closed
marco-ippolito wants to merge 1 commit intonodejs:v22.x-stagingfrom
Closed
[v22.x] Backport: "module: add --experimental-transform-types flag"#54373marco-ippolito wants to merge 1 commit intonodejs:v22.x-stagingfrom
marco-ippolito wants to merge 1 commit intonodejs:v22.x-stagingfrom
Conversation
PR-URL: nodejs#54283 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
marco-ippolito
added
the
request-ci
targos
approved these changes
Aug 14, 2024
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
Member
|
I was planning to land it on the next 22 proposal, but CI seems flaky. I will need to update v22.x-staging and then you'll need to rebase on top of it. If we get a green CI tomorrow (Monday 19) I can cherry-pick it. |
Member
Author
It seems a Macos machine disk is full, thats the failure |
Collaborator
Member
Author
|
@RafaelGSS since I saw in the proposal we unflagged detect module, the original commit should land cleanly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #54283
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: Zeyu "Alex" Yang [email protected]
Reviewed-By: Chengzhong Wu [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Paolo Insogna [email protected]
This backport simply adds the imply of
--experimental-detect-module. @targos