Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: wbluke/readable-code
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: handyejee/readable-code-study
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 20 commits
  • 27 files changed
  • 1 contributor

Commits on May 27, 2025

  1. fix: 의미있는 변수명으로 수정

    @handyejee
    handyejee committed May 27, 2025
    Configuration menu
    Copy the full SHA
    2d6f447 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2025

  1. fix: 메서드 및 변수 리팩토링

    @handyejee
    handyejee committed May 29, 2025
    Configuration menu
    Copy the full SHA
    4d8d47b View commit details
    Browse the repository at this point in the history

  2. fix: 추상화 레벨을 맞춰주기 위해서 메서드 추가 분리

    @handyejee
    handyejee committed May 29, 2025
    Configuration menu
    Copy the full SHA
    aafc0c5 View commit details
    Browse the repository at this point in the history

  3. fix: 매직넘버, 매직 스트링 상수로 추출 

    - 의미를 부여함으로 가독성과 높이고 유지보수를 용이하게 한다.
    @handyejee
    handyejee committed May 29, 2025
    Configuration menu
    Copy the full SHA
    1950a29 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2025

  1. fix: if-else문을 early return으로 변경하기

    @handyejee
    handyejee committed May 30, 2025
    Configuration menu
    Copy the full SHA
    268de6b View commit details
    Browse the repository at this point in the history

  2. fix: 사고의 depth 줄이기 

    - 중첩 반복문을 stream을 사용해 줄여보기
- 변수를 사용처 가까이에 두기
    @handyejee
    handyejee committed May 30, 2025
    Configuration menu
    Copy the full SHA
    7813a24 View commit details
    Browse the repository at this point in the history

  3. fix: 공백라인을 사용해 읽는 사람에게 로직이 분리됨을 알려줄 수 있도록 수정

    @handyejee
    handyejee committed May 30, 2025
    Configuration menu
    Copy the full SHA
    afc59e8 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2025

  1. fix: 예외처리와 exception class 설정

    @handyejee
    handyejee committed Jun 1, 2025
    Configuration menu
    Copy the full SHA
    5f576b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2025

  1. fix: Cell 클래스, 로직 분리

    @handyejee
    handyejee committed Jun 2, 2025
    Configuration menu
    Copy the full SHA
    eb1869f View commit details
    Browse the repository at this point in the history

  2. fix: input, output에 대해 srp 적용 

    - input, output 관련 내용을 클래스로 분리해 메서드에서 호출할 수 있도록 변경
    @handyejee
    handyejee committed Jun 2, 2025
    Configuration menu
    Copy the full SHA
    8659665 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2025

  1. fix: srp 프로젝트 내 적용 

    - GameBoard 관련된 로직 분리
- 인풋, 아웃풋 핸들러 생성
    @handyejee
    handyejee committed Jun 3, 2025
    Configuration menu
    Copy the full SHA
    ecb4415 View commit details
    Browse the repository at this point in the history

  2. fix: ocp 적용 

    - 새로운 요구사항인 레벨별 지뢰찾기 사이즈 제공을 위해 수정
    @handyejee
    handyejee committed Jun 3, 2025
    Configuration menu
    Copy the full SHA
    58e8d38 View commit details
    Browse the repository at this point in the history

  3. fix: LSP 적용 

    - cell 별로 분리
    @handyejee
    handyejee committed Jun 3, 2025
    Configuration menu
    Copy the full SHA
    c9e96a6 View commit details
    Browse the repository at this point in the history

  4. fix: ISP 적용 

    - 게임 시작과 게임 실행을 인터페이스로 분리
    @handyejee
    handyejee committed Jun 3, 2025
    Configuration menu
    Copy the full SHA
    2a3c51b View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2025

  1. fix: DIP 적용 

    - 기존 구현체 수준이었던 InputHandler과 OutputHandler을 추상화 클래스로 변경
    @handyejee
    handyejee committed Jun 4, 2025
    Configuration menu
    Copy the full SHA
    a3f7dae View commit details
    Browse the repository at this point in the history

  2. refactor: 스터디 카페 종류 별로 선택 목록 보여주는 부분 메서드 분리

    @handyejee
    handyejee committed Jun 4, 2025
    Configuration menu
    Copy the full SHA
    a68ce17 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2025

  1. refactor: Value Object를 적용해 불변성 동등성 유효성 검증

    @handyejee
    handyejee committed Jun 10, 2025
    Configuration menu
    Copy the full SHA
    135deab View commit details
    Browse the repository at this point in the history

  2. test: cell Position 테스트코드 추가

    @handyejee
    handyejee committed Jun 10, 2025
    Configuration menu
    Copy the full SHA
    9478a0f View commit details
    Browse the repository at this point in the history

  3. test: assertj 사용하도록 then 부분 변경 

    - 지정한 행 인덱스 반환, 지정한 열 인덱스, 음수될 경우에 예외 발생 테스트코드 추가
    @handyejee
    handyejee committed Jun 10, 2025
    Configuration menu
    Copy the full SHA
    2f74046 View commit details
    Browse the repository at this point in the history

  4. test: cell sign 확인하는 테스트 코드 추가

    @handyejee
    handyejee committed Jun 10, 2025
    Configuration menu
    Copy the full SHA
    fced683 View commit details
    Browse the repository at this point in the history
Loading