Boolean getter support added (Issue #138)#136
Boolean getter support added (Issue #138)#136bvrakvs wants to merge 9 commits intohamcrest:masterfrom
Conversation
|
Will there be any response to this pull request? Is there any possibility for this fix to be included in |
|
@bureaquete This is probably not being included because your PR has failed the Continuous Integration |
|
@mikulucky why though? Everything checks out in my local, no test failure or anything. Cannot find out the reason of CI failure. |
|
@bureaquete the test failures seem to be with your changes on OpenJDK7 https://travis-ci.org/hamcrest/JavaHamcrest/builds/111651291 |
|
@mikulucky I haven't changed anything but the file in my commits. If you check last couple pull requests, all have the same failure, but from console I cannot figure out the exact reason. |
|
It looks like the build is hitting a problem in Travis combined with a problem in the JDK. See travis-ci/travis-ci#5227 This isn't anything to do with these specific changes. |
|
@zaphod42 I tried to use the similar fix from your link, but did not resolve the build failure. Weird issue indeed... |
|
I've just added a test for what I think this problem is and it works on my machine without any code changes (Java 7). Please submit a failing test. |
|
The fundamental problem appears to be that the JAXB people didn't read the JavaBean spec. That said, I just tried a version of your code and couldn't get it to work because there's no property descriptor for is. Please add a test to demonstrate the behaviour. |
|
@sf105 I couldn't reproduce the issue I have been facing... In my code, somehow I can get a Regardless I have added an extra code in |
|
@buraequete fancy rebasing this from master, as |
This request is to support the
isprefix for Boolean object getters. Since PropertyDescriptor that is created lacksreadMethodif the getter does not start withget. For example, classes that are generated by JAXB, always contain getters for Boolean types withisprefix, and without this minor fix, I cannot match those fields in any of my UT cases.