fix(ble_gap): fix NULL deref and use-after-free in ble_gap_rx_rd_rem_ver_info_complete - #1189
Open
tahiraltundag wants to merge 1 commit into
Open
tahiraltundag wants to merge 1 commit into
tahiraltundag wants to merge 1 commit into
Conversation
…ver_info_complete conn was dereferenced after ble_hs_unlock() without NULL check, and the NULL check came after the stores. If handle is already gone (disconnect raced rem-ver complete), this panics. Also touching conn after unlock is a UAF. Check NULL and copy rem-ver fields while holding lock, save is_master flag before unlock. Mirrors the safe pattern in ble_gap_rx_rd_rem_sup_feat_complete. Fixes h2zero#1183 Signed-off-by: tahiraltundag <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1183
Crash at
ble_gap_rx_rd_rem_ver_info_completewhen remote version complete arrives after conn is already gone. Original code unlocked, then dereferencedconnwithout NULL check (panic), and NULL check came after the stores. Also touchingconnafter unlock is a UAF.Change
conn == NULLwhile holdingble_hs_lock, return earlybhc_rd_rem_ver_paramsandis_masterflag while locked, then unlockble_gap_rx_rd_rem_sup_feat_completesrc/nimble/nimble/host/src/ble_gap.c:2852Testing
git diff, logic matches upstream safe path