bring back kafka as a dev dependency#1
bring back kafka as a dev dependency#1alexanderankin wants to merge 2 commits intogudjonragnar:kafkafrom
Conversation
|
actually, as I understood testcontainers#351 we want to actively not make it a dependency because then people can choose between I think we can close this and move on with the original PR 🙏 |
|
Yes, the dependency is only there initially to implement the waiting logic, as far as i can see. |
|
I did another round, actually you do need it for running the tests too. So the simplest thing to do for right now is to add @gudjonragnar would you please make this change for us on your original PR? Just to make the tests pass. 🙏 |
|
I have added it back as a dev dependency on the original PR 👍 . Will close this one. |
No description provided.