Skip to content

bring back kafka as a dev dependency#1

Closed
alexanderankin wants to merge 2 commits intogudjonragnar:kafkafrom
alexanderankin:kafka
Closed

bring back kafka as a dev dependency#1
alexanderankin wants to merge 2 commits intogudjonragnar:kafkafrom
alexanderankin:kafka

Conversation

@alexanderankin
Copy link
Copy Markdown

No description provided.

@totallyzen
Copy link
Copy Markdown

actually, as I understood testcontainers#351 we want to actively not make it a dependency because then people can choose between python-kafka and confluent-kafka for themselves.

I think we can close this and move on with the original PR 🙏

@gudjonragnar
Copy link
Copy Markdown
Owner

Yes, the dependency is only there initially to implement the waiting logic, as far as i can see.

@totallyzen
Copy link
Copy Markdown

I did another round, actually you do need it for running the tests too.

So the simplest thing to do for right now is to add python-kafka as a dev dependency.
@alexanderankin added it as an optional dependency too, maybe no need for the latter, just the former.

@gudjonragnar would you please make this change for us on your original PR? Just to make the tests pass. 🙏

@gudjonragnar
Copy link
Copy Markdown
Owner

I have added it back as a dev dependency on the original PR 👍 . Will close this one.

@alexanderankin alexanderankin deleted the kafka branch March 4, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants