clean up PATH after changing it - #56
Merged
Merged
Conversation
Adding to the path without warning the user seems a little invasive. Can we just save the original value and change it back after our new value is done being used?
joshschmitter
requested review from
brikis98 and
yorinasub17
as code owners
September 23, 2021 15:07
infraredgirl
approved these changes
Sep 23, 2021
infraredgirl
left a comment
infraredgirl
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for the contribution!
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding to the path without warning the user seems a little invasive. Can we just save the original value and change it back after our new value is done being used?