Use a range for jinja2 dependency#18
Merged
Merged
Conversation
Hi, Thanks for fixing the issue with Jinja2 so quickly. What about using a range for this dependency, instead of using a single version? That may avoid other incompatibility issues with other libraries in the future too. The range I used in this pull request is the same we (I work with @dwsutherland who submitted the other pull request) adopted in [cylc](https://github.com/cylc/cylc/pull/2990/files#diff-2eeaed663bd0d25b7e608891384b7298R106), following what was used by [Apache Airflow](https://github.com/apache/airflow/blob/6cc7712442cf23c7f846b73030c79ba12fdf4a0e/setup.py#L329) too. Cheers
Contributor
Author
|
If merged, I don't think we need a new version right away. It doesn't even need to be merged super fast, as the 2.10.1 is just out 🙂 Tested locally too with a test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for fixing the issue with Jinja2 so quickly.
What about using a range for this dependency, instead of using a single version? That may avoid other incompatibility issues with other libraries in the future too.
The range I used in this pull request is the same we (I work with @dwsutherland who submitted the other pull request) adopted in cylc, following what was used by Apache Airflow too.
Cheers