multi line strings support#706
Merged
bbakerman merged 10 commits intoJan 23, 2018
Merged
Conversation
It doesn't have multi line comments yet
Member
|
This will wait a bit more until it the spec is ready (or almost ready) |
…-strings # Conflicts: # src/main/java/graphql/schema/idl/SchemaPrinter.java # src/test/groovy/graphql/GraphQLTest.groovy # src/test/groovy/graphql/parser/ParserTest.groovy # src/test/groovy/graphql/schema/idl/SchemaPrinterTest.groovy
Member
|
lets reevaluate it again for 6.0 |
…-strings # Conflicts: # src/main/java/graphql/language/DirectiveDefinition.java # src/main/java/graphql/language/EnumTypeDefinition.java # src/main/java/graphql/language/EnumValueDefinition.java # src/main/java/graphql/language/FieldDefinition.java # src/main/java/graphql/language/InputObjectTypeDefinition.java # src/main/java/graphql/language/InputValueDefinition.java # src/main/java/graphql/language/InterfaceTypeDefinition.java # src/main/java/graphql/language/ObjectTypeDefinition.java # src/main/java/graphql/language/ScalarTypeDefinition.java # src/main/java/graphql/language/UnionTypeDefinition.java # src/main/java/graphql/parser/GraphqlAntlrToLanguage.java # src/main/java/graphql/schema/idl/SchemaPrinter.java # src/test/groovy/graphql/parser/ParserTest.groovy
exbe
pushed a commit
to intuit/graphql-java
that referenced
this pull request
Mar 19, 2018
* First commit of multi line strings. It doesn't have multi line comments yet * End to end test * Added description concept to the type definitions * Schema Generator now supports docstring syntax as a preference * Refactored out the StringValue parsing into its own class * SchemaPrinter now has AST description support * whitespace if defined as ' ' and '\t' in graphql * Fix ups after merging master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #685
This implements multi line triple quoted strings and also has SchemaGenerator support and SchemaPrinter support