Path support when traversing graph#499
Merged
bbakerman merged 6 commits intographql-java:masterfrom Jun 18, 2017
Merged
Conversation
graphql-java#498 - now follows spec in regards to data fetcher errors
andimarek
requested changes
Jun 15, 2017
Member
andimarek
left a comment
andimarek
left a comment
There was a problem hiding this comment.
I think SerializationError must also get a path info.
bbakerman
commented
Jun 15, 2017
| @@ -286,7 +280,7 @@ public Double serialize(Object input) { | |||
| public Double parseValue(Object input) { | |||
Member
Author
There was a problem hiding this comment.
There were some copy and pasta errors in the messages. I fixed them and put the offending object in 'quotes'
bbakerman
commented
Jun 15, 2017
|
|
||
| import static graphql.Assert.assertNotNull; | ||
|
|
||
| /** |
Member
Author
There was a problem hiding this comment.
Another place that needs the path
…fetch-errors # Conflicts: # src/main/java/graphql/execution/ExecutionStrategy.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#498 - now follows spec in regards to data fetcher errors